Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] BZ#719330 - No need to spew unmounted masters to the log. ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
.................................................... Commit Message Line 7: [WIP] BZ#719330 - No need to spew unmounted masters to the log. Is it still [WIP]?
.................................................... File vdsm/storage/sp.py Line 601: self.__masterMigrate(sdUUID, msdUUID, masterVersion) wouldn't this explode when passed msdUUID=BLANK
Line 642: spUUID = self.spUUID I miss the point of this early assignment.
-- To view, visit http://gerrit.usersys.redhat.com/683 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib0044075f10171bd37613e17b46b28cd7e81dff7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com