Ayal Baron has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/BindingXMLRPC.py
Line 330: def vmGuestHibernate(self, vmId, state='disk'):
Actually hibernate implies S4, but this function is for both S4 and S3.
I agree that vmGuest... is redundant.
How about vmSuspend? (S3 is suspend to ram, S4 is suspend to disk). It also complies with
Fedora's naming.
--
To view, visit
http://gerrit.ovirt.org/1121
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>