Ayal Baron has posted comments on this change.
Change subject: vm: increase the volume extension on storage migration ......................................................................
Patch Set 1: (2 inline comments)
.................................................... File vdsm/libvirtvm.py Line 1025: Line 1026: class Drive(LibvirtVmDevice): Line 1027: VOLWM_CHUNK_MB = config.getint('irs', 'volume_utilization_chunk_mb') Line 1028: VOLWM_FREE_PCT = 100 - config.getint('irs', 'volume_utilization_percent') Line 1029: VOLWM_CHUNK_LSM_MULT = 2 # Chunk multiplier during live storage migration We need to double the time as we're performing 2 lvextend operations. User controls this by setting the first 2. Line 1030: Line 1031: def __init__(self, conf, log, **kwargs): Line 1032: if not kwargs.get('serial'): Line 1033: self.serial = kwargs.get('imageID'[-20:]) or ''
.................................................... File vdsm/vm.py Line 799: return Line 800: Line 801: if newSize is None: Line 802: # newSize is always in megabytes Line 803: newSize = (vmDrive.volExtensionChunk + took me a while to understand what's bugging me here. extendDriveVolume is called from 3 places: diskReplicateStart abnormalVmStop highWrite
in diskReplicateStart we know it should be double abnormalVmStop probably should be double too by the way as the regular flow didn't catch it in time And in any event we perform all the checks in the calling methods anyway so my point is that the size should be always passed and not calculated here. Line 804: ((vmDrive.apparentsize + constants.MEGAB - 1) / Line 805: constants.MEGAB)) Line 806: Line 807: if getattr(vmDrive, 'diskReplicate', None):
-- To view, visit http://gerrit.ovirt.org/9200 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib61375613712feb7118a80c50b73e678d257f251 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com