Change in vdsm[master]: vdsm-logrotate.conf: Add copytruncate

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-logrotate.conf: Add copytruncate
......................................................................

Patch Set 1: I would prefer that you didn't submit this

The bug here is part of libvirt log configuration, in VDSM we use logger handler that takes care of switching open files after rotate as you mentioned on the patch.

Changing the configuration of logrotate will fix the issue, but also add side effect that some logs might disappear due to the truncate. If we can fix the real cause of that open file in libvirt logger, it will be much nicer. Is it possible? did you check with libvirt guys?

Also I wonder, why if we decide to add copytruncate we still need the WatchedFileHandler, maybe we can use FileHandler and avoid other bug that related to the emit check (https://bugzilla.redhat.com/show_bug.cgi?id=919163)?

Keeping the watchedFileHandler and copytrucate without handling the cause in libvirt seems like too much work for logrotate and logger module..

--
To view, visit http://gerrit.ovirt.org/13499
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie018b2039eac565cfdb5874c664b177d6fad64fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server