Petr Horáček has posted comments on this change.
Change subject: net: tests: test_rollback ......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46875/6/tests/functional/networkTests.py File tests/functional/networkTests.py:
Line 2777: self.assertBondDoesntExist(BONDING_NAME, nics) Line 2778: Line 2779: @cleanupNet Line 2780: @ValidateRunningAsRoot Line 2781: def test_rollback(self):
what? didn't we have already this trivial test? Oops.
ConnectivityCheck test tests if rollback was done and if it removed all created networks (but it does not check reverting to initial networks) Line 2782: with dummyIf(3) as nics: Line 2783: NET1 = NETWORK_NAME + '1' Line 2784: NET2 = NETWORK_NAME + '2' Line 2785: