Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection

Yaniv Bronhaim has posted comments on this change.

Change subject: libvirtconnection: ping libvirt upon disconnection
......................................................................


Patch Set 5:

(2 comments)

....................................................
File tests/libvirtconnectionTests.py
Line 36:     VIR_FROM_REMOTE = 4
Line 37:     VIR_ERR_SYSTEM_ERROR = 5
Line 38:     VIR_ERR_INTERNAL_ERROR = 6
Line 39:     VIR_ERR_NO_CONNECT = 7
Line 40:     VIR_ERR_INVALID_CONN = 8
you can do 
 VIR_CRED_AUTHNAME, VIR_CRED_PASSPHRASE, ... = range(n)
Line 41: 
Line 42:     class libvirtError(Exception):
Line 43:         def get_error_code(self):
Line 44:             return LibvirtMock.VIR_ERR_SYSTEM_ERROR


Line 46:         def get_error_domain(self):
Line 47:             return LibvirtMock.VIR_FROM_RPC
Line 48: 
Line 49:         def get_error_level(self):
Line 50:             return 3
what is 3 ? VIR_FROM_RPC?
Line 51: 
Line 52:         def get_error_message(self):
Line 53:             return ''
Line 54: 


-- 
To view, visit http://gerrit.ovirt.org/19444
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes