Liron Ar has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/25424/3/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 206: if domain.getDomainRole() == sd.REGULAR_DOMAIN:
Line 207: continue
Line 208:
Line 209: self._backend.setDomainRegularRole(domain)
Line 210: except se.StorageDomainDoesNotExist:
We need to catch exception raised in getDomainRole and in setDomainRole.
Done
Line 211: self.log.error("Error when trying to find domain %s, ignoring",
Line 212: sdUUID, exc_info=True)
Line 213:
Line 214: @unsecured
--
To view, visit
http://gerrit.ovirt.org/25424
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar
laravot@redhat.com
Gerrit-Reviewer: Allon Mureinik
amureini@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Eduardo
ewarszaw@gmail.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Liron Ar
laravot@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Sergey Gotliv
sgotliv@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes