Saggi Mizrahi has posted comments on this change.
Change subject: storage: kill ongoing operations on exit ......................................................................
Patch Set 3:
(1 comment)
.................................................... File lib/vdsm/utils.py Line 458: Line 459: def execCmd(command, sudo=False, cwd=None, data=None, raw=False, logErr=True, Line 460: printable=None, env=None, sync=True, nice=None, ioclass=None, Line 461: ioclassdata=None, setsid=False, execCmdLogger=logging.root, Line 462: killOnExit=False): death is not more thread spcific. I spoke about two things
1. Let the user pass the signal since we might want to pass different signals to other processes 2. Make sure you can't specify this when sync=False Line 463: """ Line 464: Executes an external command, optionally via sudo. Line 465: """ Line 466: if ioclass is not None: