Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
......................................................................
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/19389/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2304: def pmWakeup(self):
Line 2305: self.log.debug('pmWakeup Called')
Line 2306: hooks.after_vm_dehibernate(self._dom.XMLDesc(0), self.conf)
Line 2307: try:
Line 2308: self._dom.pMWakeup()
This looks suspicious. AFAIK is PMWakeup(); however below you use
pmWakeup(
libvirt.virDomain has pMWakeup(self, flags) atleast in my version, could
you verify that this is wrong? pmWakeup() is to reflect the name of function we use in
order to keep conventions (imho pmWakeup is correct)
Line 2309: except:
Line 2310: self.log.error("pmWakeup failed", exc_info=True)
Line 2311: return {'status': {'code':
errCode['exist']['status']['code'],
Line 2312: 'message': 'Failed to wake up VM.'}}
Line 2339: self.log.error("pmSuspend failed", exc_info=True)
Line 2340: return {'status': {'code':
errCode['exist']['status']['code'],
Line 2341: 'message': 'Failed to suspend VM.'}}
Line 2342: else:
Line 2343: # We have to treat hybrid as standard S3
So it is impossible we get here if target is S4?
false, the
comment is only to reflect that if hybrid was called, we treat it the same way as suspend
(it's a bit tricky as hybrid should never fallback to hibernate in virtual
environment)
Line 2344: self.log.debug('pmSuspend succeeded')
Line 2345: if target in ('mem', 'hybrid'):
Line 2346: self.lastStatus = 'Paused'
Line 2347: self.conf['pauseCode'] =
targets[target]['reason']
--
To view, visit
http://gerrit.ovirt.org/19389
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes