Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: move path getters ......................................................................
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/41995/12/tests/manifest_tests.py File tests/manifest_tests.py:
Line 45: imguuid, voluuid = make_volume(manifest.domaindir, VOLSIZE) Line 46: self.assertEqual(VOLSIZE, manifest.getVSize(imguuid, voluuid)) Line 47: Line 48: def test_getisodomainimagesdir(self): Line 49: with namedTemporaryDir() as path: Do we need always temporary directory? Can use unbound manifest for testing? Line 50: manifest = self.make_manifest(path) Line 51: isopath = os.path.join(manifest.domaindir, sd.DOMAIN_IMAGES, Line 52: sd.ISO_IMAGE_UUID) Line 53: self.assertEquals(isopath, manifest.getIsoDomainImagesDir())