Dan Kenigsberg has posted comments on this change.
Change subject: Bond destroying ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Thanks, Petr, but I do not think that this patch is ready yet.
.................................................... File lib/vdsm/tool/load_needed_modules.py.in Line 18: # Line 19: Line 20: Line 21: import subprocess Line 22: import netinfo * imports of vdsm-specific modules should come after stdlib ones. * this import works "by chance". I'd rather that you use a more explicit one:
from vdsm inport netinfo Line 23: Line 24: from vdsm.tool import expose Line 25: Line 26:
-- To view, visit http://gerrit.ovirt.org/13752 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0cd27f1ff9a62e202c3513e54df5481d1b72ed7c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Sebek psebek@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Petr Sebek psebek@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server