Change in vdsm[master]: netconf: Improve unified persistence's rollback in memory.

Assaf Muller has posted comments on this change.

Change subject: netconf: Improve unified persistence's rollback in memory.
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

....................................................
File vdsm/netconf/__init__.py
Line 65:         if self.unifiedPersistence and self.runningConfig is None:
Line 66:             self.runningConfig = RunningConfig()
Line 67: 
Line 68:     def rollback(self):
Line 69:         if self.unifiedPersistence:
Currently vdsm_restore_net_config is used for on-boot restoration, and in-memory
restoration code resides in ifcfg.py. I think vdsm_restore_net_config should not have
in-memory restoration code, especially if it means that we use imp.load_source to get
access to that code. Instead you can put the in memory restore code in the RunningConfig
class.
Line 70:             restore_net = imp.load_source('restore_net',
Line 71:                                           EXT_VDSM_RESTORE_NET_CONFIG)
Line 72:             restore_net.restore_from_memory(self.runningConfig)
Line 73:             self.runningConfig = None


-- 
To view, visit http://gerrit.ovirt.org/20032
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7436976d8bacbfaa1c4b059c71c4abb46192f99a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes