Antoni Segura Puimedon has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 10: Code-Review-1
(7 comments)
Some minor changes.
http://gerrit.ovirt.org/#/c/21792/10/vdsm.spec.in File vdsm.spec.in:
Line 933: %{_datadir}/%{vdsm_name}/tc.py* Line 934: %{_datadir}/%{vdsm_name}/vdsm Line 935: %{_datadir}/%{vdsm_name}/vdsm-restore-net-config Line 936: %{_datadir}/%{vdsm_name}/vdsm-store-net-config Line 937: %{_datadir}/%{vdsm_name}/virt/vm.py* Please put the virt package together. Lines: - 910, - 930-932 - 937-939 - 960 - 1083 are the same package. Line 938: %{_datadir}/%{vdsm_name}/virt/vmexitreason.py* Line 939: %{_datadir}/%{vdsm_name}/virt/vmpowerdown.py* Line 940: Line 941: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/vdsm.conf
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/Makefile.am File vdsm/virt/Makefile.am:
Line 1: # Line 2: # Copyright 2013 Red Hat, Inc. 2014 for now ;-) Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/__init__.py File vdsm/virt/__init__.py:
Line 1 Missing copyright notice for this beautiful blank line.
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/guestIF.py File vdsm/virt/guestIF.py:
Line 25: import json Line 26: import supervdsm Line 27: import unicodedata Line 28: Line 29: import vmstatus now that this is the virt package, this line should be from . import vmstatus Line 30: Line 31: _MAX_SUPPORTED_API_VERSION = 0 Line 32: _IMPLICIT_API_VERSION_ZERO = 0 Line 33:
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 54: import caps Line 55: import guestIF Line 56: import hooks Line 57: import kaxmlrpclib Line 58: import sampling from . import sampling Line 59: import supervdsm Line 60: import vmexitreason Line 61: import vmstatus Line 62:
Line 57: import kaxmlrpclib Line 58: import sampling Line 59: import supervdsm Line 60: import vmexitreason Line 61: import vmstatus from . import vmstatus
And for the rest of imports of the virt package, the same. Line 62: Line 63: from vmpowerdown import VmShutdown, VmReboot Line 64: Line 65: _VMCHANNEL_DEVICE_NAME = 'com.redhat.rhevm.vdsm'
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/vmChannels.py File vdsm/virt/vmChannels.py:
Line 1: # Line 2: # Copyright 2012 Red Hat, Inc. This file has been modified after 2012 IIRC Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or