From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: move exec_sync_bytes to common.cmdutils.exec_cmd
......................................................................
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/79693/8/lib/vdsm/network/cmd.py
File lib/vdsm/network/cmd.py:
Line 51
Line 52
Line 53
Line 54
Line 55
Dan, did you miss my comment about the docstring and the warnings
needed he
yep
--
To view, visit
https://gerrit.ovirt.org/79693
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idca5b123a4ce6ef5ebaff8084d788e2acd47c2be
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes