Ryan Harper has posted comments on this change.
Change subject: Replace calling setSchedulerParameters() with filling its XML description. ......................................................................
Patch Set 3: No score
I support filling out the xml parameters instead of calling the setScheduleParameters, but I'd prefer to avoid the nice-level mapping. Let's just use raw cpushares values.
I see we've encoded the 'nice' level in the runningVM stats. Maybe switching nice for cgroup cpushares is a different patch.
-- To view, visit http://gerrit.ovirt.org/6290 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I211e191022f5a18fa7d97d5a8fb42e10729ddd06 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com