Change in vdsm[master]: netinfo: Simplify the check if an interface still has any ot...
Mark Wu has posted comments on this change.
Change subject: netinfo: Simplify the check if an interface still has any other users.
......................................................................
Patch Set 1: Verified
(2 inline comments)
It looks the jenkins failure is not related to the changes in this patch.
In my tests, if an interface (bond or nic) has multiple users bridgeless network and
vlans, only when the last user is removed, it will be restored to the initial bare state.
For details, please see the patch following to this one.
....................................................
File vdsm/configNetwork.py
Line 250
Line 251
Line 252
Line 253
Line 254
both the updated netinfo and old netinfo (including the interface removed already) works
fine with old implementation. if the user removed is included, discard it, otherwise also
discard with no effect.
Line 344: ifup(iface)
Line 345:
Line 346: # The (relatively) new setupNetwork verb allows to remove a network
Line 347: # defined on top of an bonding device without break the bond itself.
Line 348: _netinfo = netinfo.NetInfo()
The new implementation requires an updated netinfo snapshot after the user is removed.
This just a temporary change, so we don't need consider the optimization of reducing
instances of netinfo.
Line 349: if implicitBonding:
Line 350: if bonding and not _netinfo.ifaceHasOtherUsers(bonding):
Line 351: ifdown(bonding)
Line 352: configWriter.removeBonding(bonding)
--
To view, visit http://gerrit.ovirt.org/15416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie70cbfcc4c561c98f2e90685329900796517f933
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server