Dan Kenigsberg has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
......................................................................
Patch Set 18: Code-Review-1
I am reluctant to merge, since I have understood (guess how) that this patch does not eliminate the race between extendVG (on the SPM) and domainMonitor (on an HSM).
After getDevVis is called on HSM (but before extendVG), the domainMonitor can sample the storage, and re-create an exact same filter.
Later, after the vg is extended, the domainMonitor would report it as "partial" again.
We should find a way to halt domainMonitor on HSMs before a vgextend, and restart it later. Alternatively, Engine should ignore false negative results during that period.
Alter
--
To view, visit
http://gerrit.ovirt.org/20552
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov
pzhukov@redhat.com
Gerrit-Reviewer: Ayal Baron
abaron@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Eduardo
ewarszaw@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Lee Yarwood
lyarwood@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Pavel Zhukov
pzhukov@redhat.com
Gerrit-Reviewer: Saggi Mizrahi
smizrahi@redhat.com
Gerrit-Reviewer: Sergey Gotliv
sgotliv@redhat.com
Gerrit-Reviewer: Tomáš Došek
tdosek@redhat.com
Gerrit-Reviewer: Yeela Kaplan
ykaplan@redhat.com
Gerrit-HasComments: No