Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files ......................................................................
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/45750/3/vdsm.spec.in File vdsm.spec.in:
Line 1353: %files api Line 1354: %doc lib/api/vdsm-api.html Line 1355: %{_datadir}/%{vdsm_name}/rpc/vdsmapi-schema.json Line 1356: %{python_sitelib}/api/vdsmapi.py* Line 1357: %{python_sitelib}/api/__init__.py*
generic api package? what other projects will use this site-package and ins
I have two usage cases in mind now: 1. Using standalone client on a machine where there is no vdsm 2. Use schema for engine side communication layer validation. Line 1358: %if ! 0%{?with_gluster} Line 1359: %exclude %{_datadir}/%{vdsm_name}/rpc/vdsmapi-gluster-schema.json Line 1360: %endif Line 1361:
Line 1362: %files yajsonrpc Line 1363: %dir %{python_sitelib}/yajsonrpc Line 1364: %{python_sitelib}/yajsonrpc/betterAsyncore.py* Line 1365: %{python_sitelib}/yajsonrpc/stomp.py* Line 1366: %{python_sitelib}/yajsonrpc/stompreactor.py*
this can maybe be used by other projects as well.. so having yajsonrpc pack
My goal was to minimize code changes so I have decided to have it in vdsm/api. Whichever use case we choose it is always api that vdsm exposes. What is you suggestion for naming? Line 1367: Line 1368: %files infra Line 1369: %{python_sitelib}/%{vdsm_name}/infra/eventfd/__init__.py* Line 1370: %{python_sitelib}/%{vdsm_name}/infra/filecontrol/__init__.py*