Change in vdsm[master]: vm: increase the volume extension on storage migration

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: vm: increase the volume extension on storage migration
......................................................................

Patch Set 2: (2 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 1064:         extension is in order (thin provisioning on block devices).
Line 1065:         """
Line 1066:         return self.VOLWM_FREE_PCT * self.volExtensionChunk * (2 ** 20 / 100)
Line 1067: 
Line 1068:     def getNextVolumeExtSize(self):
This could be a property too, even though since it is explicitly a calculation whose result is intended to change I picked a method.
Line 1069:         """
Line 1070:         Returns the next volume size in megabytes. This value is based on the
Line 1071:         volExtensionChunk property and it's the size that should be requested
Line 1072:         for the next LV extension.

....................................................
File vdsm/vm.py
Line 809:     def _rtcUpdate(self, timeOffset):
Line 810:         self.log.debug('new rtc offset %s', timeOffset)
Line 811:         self.conf['timeOffset'] = timeOffset
Line 812: 
Line 813:     def extendDriveVolume(self, vmDrive):
You probably (initially) asked the opposite but I figured out that if we make the newSize mandatory then we have 2 similar calls:

vmDrive.extendDriveVolume(vmDrive.getNextVolumeExtSize())

And we also might need to move the vmDrive.blockDev check into the getNextVolumeExtSize method (I didn't verify it but it might be problematic and we might need it there too). That said, if you still prefer to have the above format I'll go ahead and make the change.
Line 814:         if not vmDrive.blockDev:
Line 815:             return
Line 816: 
Line 817:         newSize = vmDrive.getNextVolumeExtSize()  # newSize is in megabytes

--
To view, visit http://gerrit.ovirt.org/9200
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib61375613712feb7118a80c50b73e678d257f251
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server