Igor Lvovsky has posted comments on this change.
Change subject: improve add/del bridgesless network ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
.................................................... File vdsm/netinfo.py Line 94: ports = os.listdir(bridgePath) os.path.join(bridgePath) is do nothing in your case. I think you meant to:
bridgePath = os.path.join('/sys/class/net' + bridge + 'brif') if os.path.exists(bridgePath): ...
Line 103: mtu = file(ifacePath).readline().rstrip() again, there is no need in os.path.join(ifacePath), just ifacePath
Line 113: same as above
-- To view, visit http://gerrit.ovirt.org/3615 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f170eaced2d6f756b84cb52e9efce6dc9722405 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com