Igor Lvovsky has posted comments on this change.
Change subject: Check if block device without invoking storage subsystem ......................................................................
Patch Set 6: Do not submit
(2 inline comments)
The first part of this patch (block device investigation) is absolutely right, but the second part (preparePaths) is wrong (why it here at all?).
.................................................... File vdsm/vm.py Line 565: def preparePaths(self): No, you can't do it. We have call of this function with drives parameter
Line 566: for drive in self.conf.get('drives', []): Why you need it? It's wrong since my refactoring patch, you shouldn't use self.conf.get('drives') anymore. Now we have 'devices' instead of drives.
-- To view, visit http://gerrit.ovirt.org/678 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com