Change in vdsm[master]: xmlrpc: rename binding

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: xmlrpc: rename binding
......................................................................

Patch Set 9: Code-Review-1

(5 comments)

2 patches: 
1. rename "binding" to "server" - explain why 
2. rename "xmlrpc" places to "http" to still use xmlrpc code - also explain for what we use it

https://gerrit.ovirt.org/#/c/72768/9/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 206: 
Line 207:         ('fake_sriov_enable', 'false',
Line 208:          'Enable reporting of fake SR-IOV devices.'),
Line 209: 
Line 210:         ('http_enable', 'true', 'Enable the http server'),
weird change.. I would explain where the config is used now when xmlrpc is removed.
Line 211: 
Line 212:         ('jsonrpc_enable', 'true', 'Enable the JSON RPC server'),
Line 213: 
Line 214:         ('broker_enable', 'false', 'Enable outgoing connection to broker'),

https://gerrit.ovirt.org/#/c/72768/9/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:

Line 243: 
Line 244: def Host_getCapabilities_Ret(server_address, ret):
Line 245:     """
Line 246:     We need to add additional information to getCaps as it was done for xmlrpc.
Line 247:     """
not related of course..
Line 248:     ret['info']['lastClientIface'] = getDeviceByIP(server_address)
Line 249: 
Line 250:     return ret['info']
Line 251:

https://gerrit.ovirt.org/#/c/72768/9/tests/clientif_test.py
File tests/clientif_test.py:

Line 51:         self.channelListener = None
Line 52:         self.vmContainerLock = threading.Lock()
Line 53:         self.vmContainer = {}
Line 54:         self.vmRequests = {}
Line 55:         self.servers = {}
why the renaming?
Line 56:         self._recovery = False
Line 57: 
Line 58:     def createVm(self, vmParams, vmRecover=False):
Line 59:         self.vmRequests[vmParams['vmId']] = (vmParams, vmRecover)

https://gerrit.ovirt.org/#/c/72768/9/vdsm.spec.in
File vdsm.spec.in:

Line 245: Obsoletes: %{name}-xmlrpc < %{version}-%{release}
Line 246: 
Line 247: %description http
Line 248: A http interface for interacting with vdsmd when using OVF store image
Line 249: download or upload.
this phrase should be in the commit msg - we still use xmlrpc code as http server listener for using OVF store images.... and attach the relevant RFE bugzilla that introduce that maybe for extra fun
Line 250: 
Line 251: %package client
Line 252: Summary:        VDSM client
Line 253: BuildArch:      noarch

https://gerrit.ovirt.org/#/c/72768/9/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 258:                 self.servers['http'] = http_server
Line 259:                 http_detector = HttpDetector(http_server)
Line 260:                 self._acceptor.add_detector(http_detector)
Line 261: 
Line 262:     def _prepareJSONRPCBinding(self):
now you need to change this also to Server.. do the renaming in different patch.
Line 263:         if config.getboolean('vars', 'jsonrpc_enable'):
Line 264:             try:
Line 265:                 from vdsm.rpc import Bridge
Line 266:                 from vdsm.rpc.bindingjsonrpc import BindingJsonRpc