Nir Soffer has posted comments on this change.
Change subject: utils: Correct and faster list2cmdline
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27548/6/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 657: parts = []
Line 658: for arg in args:
Line 659: if _needs_quoting(arg) or arg == '':
Line 660: quoted = ("'" + s + "'" for s in arg.split("'"))
Line 661: arg = r"'".join(quoted)
I suggest:
Nice!
Since you already tested and profiled it, I suggest that you upload the next patch with this change and updated commit message and mark it as verified.
Line 662: parts.append(arg)
Line 663: return ' '.join(parts)
Line 664:
Line 665:
--
To view, visit
http://gerrit.ovirt.org/27548
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc7819c126fe51cc068cc6f9f85b1002878385b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Adam Litke
alitke@redhat.com
Gerrit-Reviewer: Allon Mureinik
amureini@redhat.com
Gerrit-Reviewer: Alon Bar-Lev
alonbl@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Saggi Mizrahi
smizrahi@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes