Edward Haas has posted comments on this change.
Change subject: storage: prepare iscsi for IPv6 targets
......................................................................
Patch Set 11:
(3 comments)
https://gerrit.ovirt.org/#/c/65696/11/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
PS11, Line 59: getTargetString
How about 'portal_join'?
On another thought, are you sure this func is needed?
Looks like the func is trying to find a common usage for creating a portal, but it is not
really common when you need to use so many branches inside.
I think you can drop it and use hosttail_join at the callers.
PS11, Line 60: if tpgt is None:
: tpgtStr = ""
: else:
: tpgtStr = ",%d" % tpgt
Python using the Hungarian notation is a bit too much for me :)
anyway, this may look a bit nicer:
tag = ",%d" % tpgt if tpgt else ""
Same for iqn
PS11, Line 71: str(portal.port)),
This one does not fit the previous line?
--
To view, visit
https://gerrit.ovirt.org/65696
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1e1ffe1c5d09b7bc3767d84a99711986eaef97
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes