Ayal Baron has posted comments on this change.
Change subject: walk around threading and pipe problem ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(6 inline comments)
][
.................................................... File vdsm/betterThreading.py Line 115: self.lockPipe = storage.misc.ThreadPipeLock I believe threadPipeLock should be defined here and imported in storage.misc, not the other way around.
.................................................... File vdsm/storage/misc.py Line 79: ThreadPipeLock = threading.Lock() s/Thread/thread/
Line 220: with disabledGcBlock: why not: with ThreadPipeLock, disabledGcBlock:
Line 226: trailing spaces are frowned upon.
Line 231: ThreadPipeLock.release() redundant if used with "with" as above
Line 248: ThreadPipeLock.release() redundant if used with "with" as above
-- To view, visit http://gerrit.ovirt.org/3638 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming sming56@gmail.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com