Dan Kenigsberg has posted comments on this change.
Change subject: net: test_setupNetworks_bond_with_custom_option with ifcfg persistence ......................................................................
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/43467/2/tests/functional/networkTests.py File tests/functional/networkTests.py:
Line 2458: self.vdsm_net.save_config() Line 2459: Line 2460: @cleanupNet Line 2461: @ValidateRunningAsRoot Line 2462: def test_setupNetworks_bond_with_custom_option(self): please state that this test only checks that "custom=foo" is does not harm the configuration of the bond. Line 2463: with dummyIf(2) as nics: Line 2464: status, msg = self.setupNetworks( Line 2465: {}, Line 2466: {BONDING_NAME: {'nics': nics,
Line 2467: 'options': 'custom=foo mode=balance-rr'}}, Line 2468: NOCHK, test_kernel_config=False) Line 2469: self.assertEqual(status, SUCCESS, msg) Line 2470: self.assertBondExists(BONDING_NAME, nics) Line 2471: if vdsm.config.config.get('vars', 'net_persistence') == 'unified': it is a functional test - why don't you just add the expected bond options to assertBondExists() ? Line 2472: opts = self.vdsm_net.config.bonds.get( Line 2473: BONDING_NAME).get('options') Line 2474: self.assertEquals(opts, 'mode=balance-rr') Line 2475: else: # ifcfg persistence