Francesco Romani has posted comments on this change.
Change subject: dump the core of a VM
......................................................................
Patch Set 17:
(2 comments)
http://gerrit.ovirt.org/#/c/7329/17/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 5898: # @live: Do not interrupt the running VM
Line 5899: #
Line 5900: # @reset: Reboot the VM after gathering core dump
Line 5901: #
Line 5902: # Since: 4.14.2
4.15.0?
Drop this, I overlooked the tag list.
Line 5903: ##
Line 5904: {'enum': 'CoreDumpPostAction', 'data':
['crash', 'live', 'reset']}
Line 5905:
Line 5906: ##
Line 5917: # @bypassCache: #optional Avoid file system cache when saving
Line 5918: #
Line 5919: # @memoryOnly: #optional Dump VM's memory only
Line 5920: #
Line 5921: # Since: 4.14.2
same here
Of course drop this one as well.
Line 5922: #
Line 5923: ##
Line 5924: {'command': {'class': 'VM', 'name':
'coreDump'},
Line 5925: 'data': {'to': 'str', 'postAction':
'CoreDumpPostAction',
--
To view, visit
http://gerrit.ovirt.org/7329
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-HasComments: Yes