Federico Simoncelli has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
......................................................................
Patch Set 18: Code-Review+1
Dan it seems that such race could not exist, I've been convinced to think that the flow would be:
- connectStorageServer
- getDevicesVisibility (refresh filters including the new devices)
- extendStorageDomain (on SPM)
Let's be clear, I'm not thrilled by this solution at all, but if the assumption above is correct, it seems that it's the only thing that we can do now.
I don't feel comfortable enough to give more than a +1.
--
To view, visit
http://gerrit.ovirt.org/20552
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov
pzhukov@redhat.com
Gerrit-Reviewer: Ayal Baron
abaron@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Eduardo
ewarszaw@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Lee Yarwood
lyarwood@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Pavel Zhukov
pzhukov@redhat.com
Gerrit-Reviewer: Saggi Mizrahi
smizrahi@redhat.com
Gerrit-Reviewer: Sergey Gotliv
sgotliv@redhat.com
Gerrit-Reviewer: Tomáš Došek
tdosek@redhat.com
Gerrit-Reviewer: Yeela Kaplan
ykaplan@redhat.com
Gerrit-HasComments: No