Change in vdsm[master]: osinfo: properly parse kernel compile time

[Martin Polednik]

Martin Polednik has posted comments on this change.

Change subject: osinfo: properly parse kernel compile time
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:

Line 178:     return selinux
Line 179: 
Line 180: 
Line 181: def package_versions():
Line 182:     def kernelDict():
>  martin, that's why i think (as we discussed) that we should
> rather drop the 
Dan, the patch literally changes 2 characters if you ignore the
comment - I wonder how does that make it harder to understand.

Michal, I fear dropping buildtime just from this single package - we query rpmdb for
buildtimes of other packages, that makes me feel slightly uneasy removing it in just this
case as well as in all packages case.
Line 183:         ret = os.uname()
Line 184:         try:
Line 185:             ver, rel = ret[2].split('-', 1)
Line 186:         except ValueError:


-- 
To view, visit https://gerrit.ovirt.org/65059
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacc9b0fe5446abd5405db6efff6b7f9f16468bc9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes