Federico Simoncelli has posted comments on this change.
Change subject: Add hotPlug/hotUnplug disk feature
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 1284: self._devices[vm.DISK_DEVICES].append(drive)
In the scenario 1 do we have all the needed information in libvirt (so that we can rebuild
the drive object/conf)?
Line 1297: for drv in self._devices[vm.DISK_DEVICES][:]:
I accepted your comments on my live snapshot patch assuming that you verified that
"[:]" is atomic/thread-safe. If not it's just a costly operation and we
might need to find a better solution in the future. Let's just not forget about this.
--
To view, visit
http://gerrit.ovirt.org/1108
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecab9e28b2e77cfeedc3b9068095f7d117eb6221
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>