Liron Aravot has posted comments on this change.
Change subject: hsm: prepareForShutdown - operations order ......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/36162/4/vdsm/storage/hsm.py File vdsm/storage/hsm.py:
Line 3452: self.log.warning("Failed to stop RepoStats thread", Line 3453: exc_info=True) Line 3454: Line 3455: self.taskMng.prepareForShutdown() Line 3456: sp.StoragePool.cleanupMasterMount()
The easy fix would be to remove the code that always fail in the current wa
Nir, the current code doesn't always fail..it will fail only for block storage while working on any other storage type..so i wouldn't just remove it. I can move prepare for shutdown "up", so it'll be executed immediately after cleanupMasterMount() if you prefer it.
what do you think? Line 3457: except: Line 3458: pass Line 3459: Line 3460: @classmethod