Change in vdsm[master]: libvirtvm: fix xml generation for all the devices

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: libvirtvm: fix xml generation for all the devices
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

oh dear. will get to unbreak master first thing tomorrow.

....................................................
File vdsm/libvirtvm.py
Line 1304: 
Line 1305:         for devType in self._devices:
Line 1306:             for dev in self._devices[devType]:
Line 1307:                 if hasattr(dev, 'custom'):
Line 1308:                     yield
yield None?
Line 1309: 
Line 1310:     def _beforeDeviceCreateHooks(self, dev):
Line 1311:         """
Line 1312:         Run before_device_create hook script for devices with custom properties

--
To view, visit http://gerrit.ovirt.org/13637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb4f9eb32bc58371cec66301275689660193447b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Assaf Muller 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server