Petr Šebek has posted comments on this change.
Change subject: Bond destroying ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/configNetwork.py Line 517: self._backup(netinfo.NET_CONF_PREF + bonding) Line 518: self._removeFile(netinfo.NET_CONF_PREF + bonding) Line 519: if bonding not in ['bond0', 'bond1', 'bond2', 'bond3', 'bond4']: Line 520: with open(BONDING_MASTERS, 'w') as f: Line 521: f.write("-%s\n" % bonding) But ifdown(bonding) is already called in configNetwork.delNetwork() at line 1137 before configWriter.removeBonding(). Line 522: Line 523: Line 524: def removeBridge(self, bridge): Line 525: ifdown(bridge)
-- To view, visit http://gerrit.ovirt.org/13752 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0cd27f1ff9a62e202c3513e54df5481d1b72ed7c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek psebek@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Petr Šebek psebek@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server