Dan Kenigsberg has posted comments on this change.
Change subject: Make the xmlrpc binding run in a thread ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
very minor comment; I'd like to see this (and following patch) in.
.................................................... File vdsm/BindingXMLRPC.py Line 77: self.thread = threading.Thread(target=threaded_start, I love stating private implementation details as such (self._thread)
-- To view, visit http://gerrit.ovirt.org/3891 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic0ea2589d5cb258c4b8d3d82d4f9c390b702a24f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com