Dan Kenigsberg has uploaded a new change for review.
Change subject: PARTIAL: explicitly close libvirt connection after use ......................................................................
PARTIAL: explicitly close libvirt connection after use
Otherwise, libvirt cries about
: error : virNetSocketReadWire:1184 : End of file while reading data: Input/output error
TODO: fix other usages of libvirtconnection.get().
Change-Id: I2b15f3ab017828a63960ba9311fa2bf6bfab4729 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/tool/dummybr.py 1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/17192/1
diff --git a/lib/vdsm/tool/dummybr.py b/lib/vdsm/tool/dummybr.py index 762e726..68a9568 100644 --- a/lib/vdsm/tool/dummybr.py +++ b/lib/vdsm/tool/dummybr.py @@ -20,6 +20,7 @@
import os +import contextlib
from vdsm.netinfo import DUMMY_BRIDGE from vdsm import libvirtconnection, utils, constants @@ -34,11 +35,11 @@
def addBridgeToLibvirt(bridgeName): - conn = libvirtconnection.get(None, False) - if bridgeName not in conn.listNetworks(): - conn.networkCreateXML( - '''<network><name>%s</name><forward mode='bridge'/><bridge ''' - '''name='%s'/></network>''' % (bridgeName, bridgeName)) + with contextlib.closing(libvirtconnection.get(None, False)) as conn: + if bridgeName not in conn.listNetworks(): + conn.networkCreateXML( + '''<network><name>%s</name><forward mode='bridge'/><bridge ''' + '''name='%s'/></network>''' % (bridgeName, bridgeName))
@expose('dummybr') def main():