Adam Litke has posted comments on this change.
Change subject: guarded: Raise if attempt to lock will deadlock
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/64977/1/lib/vdsm/storage/guarded.py
File lib/vdsm/storage/guarded.py:
PS1, Line 83: by_ns_name = operator.attrgetter("ns", "name")
: for _, group in itertools.groupby(locks, by_ns_name):
Interesting. I've never run into operator.attrgetter and itertools.groupby before. Neat.
--
To view, visit
https://gerrit.ovirt.org/64977
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cd539548eda04ac7b9faf0ba1be49f29bfa2ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Adam Litke
alitke@redhat.com
Gerrit-Reviewer: Freddy Rolland
frolland@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes