ShaoHe Feng has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 7: I would prefer that you didn't submit this
(3 inline comments)
.................................................... File vdsm/API.py Line 299: if not v: Line 300: return errCode['noVM'] Line 301: return v.coreDump(to, dumpParams) Line 302: Line 303: def dumpCancel(self): coreDumpCancel Line 304: """ Line 305: Cancel a currently outgoing core dump process. Line 306: """ Line 307: v = self._cif.vmContainer.get(self._UUID)
.................................................... File vdsm_api/vdsmapi-schema.json Line 5510: {'command': {'class': 'VM', 'name': 'coreDump'}, Line 5511: 'data': {'to': 'str', 'params': 'DumpParams'}} Line 5512: Line 5513: ## Line 5514: # @VM.dumpCancel: coreDumpCancel Line 5515: # Line 5516: # Cancel the currently outgoing core dump process. Line 5517: # Line 5518: # Since: 4.10.4
Line 5517: # Line 5518: # Since: 4.10.4 Line 5519: # Line 5520: ## Line 5521: {'command': {'class': 'VM', 'name': 'dumpCancel'}} coreDumpCancel Line 5522: Line 5523: ## Line 5524: # @VM.monitorCommand: Line 5525: #
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server