Liron Ar has posted comments on this change.
Change subject: vm: pre-validate disks for snapshot ......................................................................
Patch Set 5:
(1 comment)
.................................................... File vdsm/vm.py Line 3712: for vmDevName, vmDevice in newDrives.iteritems(): Line 3713: # Adding the device before requesting to prepare it as we want Line 3714: # to be sure to teardown it down even when prepareVolumePath Line 3715: # failed for some unknown issue that left the volume active. Line 3716: preparedDrives.append(vmDevice) that's not what _rollbackDrives expects, it uses both the vmDevice and the name. Line 3717: try: Line 3718: newDrives[vmDevName]["path"] = \ Line 3719: self.cif.prepareVolumePath(newDrives[vmDevName]) Line 3720: except Exception: