Alon Bar-Lev has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
......................................................................
Patch Set 7:
Looking into the future, we may find a bug in the deactivation code, and then we would have to fix both upstream copy and downstream copy. So not only we have more work now, we will have more work in the future.
nobody cares about downstream, this is upstream project.
--
To view, visit
http://gerrit.ovirt.org/20720
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Allon Mureinik
amureini@redhat.com
Gerrit-Reviewer: Alon Bar-Lev
alonbl@redhat.com
Gerrit-Reviewer: Ayal Baron
abaron@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No