Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
......................................................................
Patch Set 11:
(2 comments)
http://gerrit.ovirt.org/#/c/20808/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 825:
Line 826: if ret == 0 and 'Not' not in out:
Line 827: # Avoid error string - 'Not Settable' or 'Not
Present'
Line 828: __hostUUID = out.strip()
Line 829: elif force:
and expose the structure of the id as uuid? instead of having this at
one p
it is valid way to sign UUID to host for now. later we'll find better
unique UUID on ppc or other arcs that don't retreive uuid by dmidecode. so force it
is.. its not simple getter, its a getter with a bit of logic
Line 830: hostid = str(uuid.uuid4())
Line 831: with open(constants.P_VDSM_NODE_ID, 'w') as f:
Line 832: f.write("%s\n", hostid)
Line 833: ovirtNodePersist([constants.P_VDSM_NODE_ID])
Line 827: # Avoid error string - 'Not Settable' or 'Not
Present'
Line 828: __hostUUID = out.strip()
Line 829: elif force:
Line 830: hostid = str(uuid.uuid4())
Line 831: with open(constants.P_VDSM_NODE_ID, 'w') as f:
the entire idea of force is to fail if not succeeding... no?
return None it is count as failure in that part, so i prefer it cleaner
Line 832: f.write("%s\n", hostid)
Line 833: ovirtNodePersist([constants.P_VDSM_NODE_ID])
Line 834: __hostUUID = hostid
Line 835: else:
--
To view, visit
http://gerrit.ovirt.org/20808
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes