Saggi Mizrahi has posted comments on this change.
Change subject: storage: kill ongoing operations on exit ......................................................................
Patch Set 3: Code-Review-1
(2 comments)
.................................................... File lib/vdsm/utils.py Line 458: Line 459: def execCmd(command, sudo=False, cwd=None, data=None, raw=False, logErr=True, Line 460: printable=None, env=None, sync=True, nice=None, ioclass=None, Line 461: ioclassdata=None, setsid=False, execCmdLogger=logging.root, Line 462: killOnExit=False): instead of killOnExist change to deathSignal
Also deathsignal is sent when the current thread dies and not when the process dies. I would rather you block the use of sync=false and a death signal together to prevent people from making stupid mistakes. Line 463: """ Line 464: Executes an external command, optionally via sudo. Line 465: """ Line 466: if ioclass is not None:
.................................................... File vdsm/storage/storage_mailbox.py Line 79: vars.task = ctask Line 80: ctask.prepare(cmd, *args) Line 81: Line 82: Line 83: def mboxExecCmd(*args, **kwargs): I assume this is module private _mbox... Line 84: kwargs['killOnExit'] = True Line 85: return misc.execCmd(*args, **kwargs) Line 86: Line 87: