Alon Bar-Lev has posted comments on this change.
Change subject: storage: set block schedule elevator using udev ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vdsm.spec.in Line 515: rules="/lib/udev/rules.d/12-vdsm-elevator.rules" Line 516: if [ -f "${rules}.lock" ]; then Line 517: rm -f "${rules}.lock" Line 518: else Line 519: rm -f "${rules}" Right. this is the whole point. Had we done this all over again, we would have just put the rules. Every time the package was updated the rules were also updated.
This is what differ rules that ar within /lib/udev and /etc/udev... they are controlled by the package not the user. Line 520: fi Line 521: fi Line 522: Line 523: exit 0
-- To view, visit http://gerrit.ovirt.org/8700 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Fabian Deutsch fabiand@fedoraproject.org Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com