Change in vdsm[master]: Add deathSignal options to better popen

Shu Ming has posted comments on this change.

Change subject: Add deathSignal options to better popen
......................................................................

Patch Set 13: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/betterPopen/createprocess.c
Line 315:             rv = read(errnofd[0], &childErrno, sizeof(int));
Line 316:             if (rv < 0) {
Line 317:                 switch (errno) {
Line 318:                     case EINTR:
Line 319:                     case EAGAIN:
errnofd[] are blocking  IO fds here, see the code line 226.  pipe() system call should return non-blocking fds without O_NONBLOCK set manually.  So EAGAIN is not a possible error value for the read() call here, EAGAIN is only for non-blocking fds.  Tough it is not harmful to handle  EAGAIN case here, I would suggest to remove EAGAIN in case of  confusing.  Please ignore my previous comments about EAGAIN.  So you only need handle EINTR here.
Line 320:                         break;
Line 321:                     default:
Line 322:                         PyErr_SetString(PyExc_OSError, strerror(childErrno));
Line 323:                         goto fail;

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server