Yeela Kaplan has posted comments on this change.
Change subject: Reduce the number of getVolumeSize() calls. ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
.................................................... File vdsm/storage/blockVolume.py Line 188: dom.sdUUID, volUUID, exc_info=True) Line 189: Line 190: return (dom.sdUUID, mdSlot) Line 191: Line 192: def delete(self, zeroLen, force): The idea is great!
But I think there's no reason to change the argument purpose and behavior.
postZero is a much better argument and more readable than zeroLen.
I would just move the getVolumeSize call into the 'if postZero' block.
Which would leave us with the better argument 'postZero' and also would save us redundant changes in the other classes. Line 193: """ Delete volume Line 194: 'zeroLen' - zeroes to write before file deletion. Line 195: 'force' is required to remove shared and internal volumes Line 196: """