Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: vdsm-tool: vdsm-id: add force option to force generate id
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/20808/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 825: 
Line 826:                 if ret == 0 and 'Not' not in out:
Line 827:                     # Avoid error string - 'Not Settable' or 'Not
Present'
Line 828:                     __hostUUID = out.strip()
Line 829:                 elif force:
>  Isn't there a stage where we can call 
and expose the
structure of the id as uuid? instead of having this at one place?
Line 830:                     hostid = str(uuid.uuid4())
Line 831:                     with open(constants.P_VDSM_NODE_ID, 'w') as f:
Line 832:                         f.write("%s\n", hostid)
Line 833:                     ovirtNodePersist([constants.P_VDSM_NODE_ID])


-- 
To view, visit http://gerrit.ovirt.org/20808
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes