Piotr Kliczewski has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.connectStorageServer
......................................................................
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/59701/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line 341
Line 342
Line 343
Line 344
Line 345
Why did you removed these?
Those types are not used. We use
plain user and password.
Line 5593
Line 5594
Line 5595
Line 5596
Line 5597
Do not remove these - these are the correct values that should be
used in n
Done
Line 5543: 1: The Storage Domain uses Network File System based storage
Line 5544: 0: The type is not known
Line 5545: 6: The Storage Domain uses posix file system
Line 5546: 7: The Storage Domain uses glusterfs
Line 5547: 8: The Storage Domain uses cinder
We don't have this type and we will never have this. Cinder is
not a storag
Those values are taken from the engine enum. Will remove cinder.
Line 5548:
Line 5549: StorageDomainInfo: &StorageDomainInfo
Line 5550: added: '3.1'
Line 5551: description: Information about a Storage Domain.
--
To view, visit
https://gerrit.ovirt.org/59701
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9fe2ffc3bc2327eefaae794b7b366e8202d2f2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes