Alon Bar-Lev has posted comments on this change.
Change subject: Add man page for vdsm.conf ......................................................................
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/22891/1/vdsm/vdsm.conf.5 File vdsm/vdsm.conf.5:
Line 42: .SH CONFIGURATION BY SECTION (EXAMPLE) Line 43: .PP Line 44: .B [vars] Line 45: Line 46: \fBcore_dump_enable\fR = true
Nice idea, but this section should be auto-generated from config.py.
I agree, no reason for doc duplications.
I also do not understand why do we need man page... and if we forced to, we can have one liner... refer to /usr/share/doc/vdsm.conf.example. Line 47: .br Line 48: Enable core dump Line 49: Line 50: \fBhost_mem_reserve\fR = 256
Line 104: Maximum concurrent outgoing migrations Line 105: Line 106: \fBsys_shutdown_timeout\fR = 10 Line 107: .br Line 108: Destroy and shutdown timeouts (in sec) before completing the action. space Line 109: Line 110: \fBuser_shutdown_timeout\fR = 30 Line 111: .br Line 112: Grace period (seconds) to let guest user close his applications before shutdown.