Change in vdsm[master]: lib: executor: handle timeout=None in __repr__

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has submitted this change and it was merged.

Change subject: lib: executor: handle timeout=None in __repr__
......................................................................


lib: executor: handle timeout=None in __repr__

After the change 54b79818e17e44ba1acf7d47e79a7e7946b50b4f we could have
timeout=None much more often.
This exposed one bug in the __repr__ method of executor.Task if timeout
is indeed None, the format string expodes with

  File "/home/fromani/Projects/upstream/vdsm/lib/vdsm/executor.py", line 377, in
__repr__
    id(self)
TypeError: %d format: a number is required, not NoneType

This patch fixes that.

Change-Id: I5960673cd97e261d7296db27dd9a1c62931989ac
Bug-Url: https://bugzilla.redhat.com/1428415
Backport-To: 4.1
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
---
M lib/vdsm/executor.py
M tests/executor_test.py
2 files changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/75059
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5960673cd97e261d7296db27dd9a1c62931989ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;