Change in vdsm[master]: py3: make toolBondingTests pass

Petr Horáček has posted comments on this change.

Change subject: py3: make toolBondingTests pass
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/65666/1/lib/vdsm/network/netinfo/bonding.py
File lib/vdsm/network/netinfo/bonding.py:

Line 258: 
Line 259: 
Line 260: def _bond_opts_name2numeric_scan(opt_path):
Line 261:     vals = {}
Line 262:     with open(opt_path, 'w') as opt_file:
why do we use open as a context manager if we close it ourselves anyways? won't be
better to create open_ignoring_flush_error that will do open and ignoring close?
Line 263:         for numeric_val in range(32):
Line 264:             name, numeric = _bond_opts_name2numeric_getval(opt_path, opt_file,
Line 265:                                                            numeric_val)
Line 266:             if name is None:


-- 
To view, visit https://gerrit.ovirt.org/65666
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4487b787c3a14ca9508847572622f431f1188e7f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <leon.otium(a)gmail.com&gt;
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes