Yaniv Bronhaim has posted comments on this change.
Change subject: Make svdsm files depend on path definitions ......................................................................
Patch Set 2: Verified; I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/supervdsm.py Line 45: Line 46: raise RuntimeError("SuperVDSM Server not found") Line 47: Line 48: VAR_RUN_VDSM = constants.P_VDSM_RUN Line 49: PIDFILE = os.path.join(VAR_RUN_VDSM, "svdsm.pid") I agree. Line 50: ADDRESS = os.path.join(VAR_RUN_VDSM, "svdsm.sock") Line 51: SUPERVDSM = __supervdsmServerPath() Line 52: Line 53:
-- To view, visit http://gerrit.ovirt.org/7540 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia952e930d719c65a9bc503f8a097bdfc26b5a397 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server